dsoprea / RijndaelPbkdf

Pure-Python Rijndael and PBKDF2 package. Python2 and Python3 compatible.
GNU General Public License v2.0
12 stars 4 forks source link

Upgrading from 0.2.6 to 0.2.7 installs test dependencies #8

Open ashokdelphia opened 4 years ago

ashokdelphia commented 4 years ago

If I upgrade using poetry with poetry update --lock pprp, I get nose and coverage installed as non-dev dependencies.

In a vanilla Python 3.7 virtualenv:

$ pip -q install pprp
$ pip freeze
coverage==5.2
nose==1.3.7
pprp==0.2.7

Is that expected behaviour?

I would expect them only to be test dependencies for the project itself, not pulled in for downstream projects that use pprp.

I think the change came as part of 90b3d0c7bcc4f10f2349432a3131940d64f545d5, but I'm not very familiar with setup.py and packaging python libraries, so can't easily offer a code change to fix it.

arthurdarcet commented 3 years ago

As far as I can see, the 0.2.7 update killed the py3 code, and kept the py2 version… We'll stick with 0.2.6 for now here