search

dsp-uga / Team-Marianne-p2

https://github.com/dsp-uga
MIT License
0 stars 0 forks source link

The main method of the ByteFeature.py file can be moved to __main__.py #3

Closed ankit-vaghela30 closed 6 years ago

ankit-vaghela30 commented 6 years ago

Just to keep everything consistent, the main code from ByteFeature.py can be moved to main.py. We should keep only class and it's methods in ByteFeature.py, Import this python file in main.py and call everything from there. Once we implement models, the main method of that python file will also be moved to main.py. This would make sure that at the end, user will only have to call main.py

Also according to coding standard, the name of the python file is not camel cased but the name of the class is. We can change name of the python file to byte_feature.py

vinayawsm commented 6 years ago

@SundayWang Also, can you please comment the lines 98-127 of ByteFeature.py? What do trainData and TestData contain?

ankit-vaghela30 commented 6 years ago

Closing this issue as the main method got committed