Closed dreddi closed 1 year ago
Bug: control label only updates correctly for the channel selected in the GUI (Ch1 in single mode, the selected channel in multi mode). Control label gets stuck when a different channel's value is changed. Will fix.
Bugs fixed, ready to merge. Original post has been updated.
Ran clang-format
on the lines of code I touched, using source/.clang-format
as a ruleset
thanks for the suggestion, I added it meanwhile
Fixes #132
Solution:
We patch
Virus::Controller::sendParameterChange
to update the GUI control label on every parameter change.This is achieved by implementing a new
VirusEditor::updateControlLabel
that takes apluginLib::Parameter
as an argument, and updates the control label using its fields. We refactor the existing code to ensure thatFocusedParameterTooltip
behaviour continues as before.Examples:
Other changes:
juce::Component
duringtemplate <typename T> T* UiObject::createJuceObject(Editor& _editor, T* _object)
, so that we can match on this key by callingcomponent.getComponentID()
, for example. We use this when checking whether a component exists on a particular page (forFocusedParameterTooltip
).Possible improvements:
m_bindings
vector linearly, on every single parameter change.~ This code has been made redundant.parameterDescriptions_C.json
.