search

dsp56300 / gearmulator

Emulation of classic VA synths of the late 90s/2000s that are based on Motorola 56300 family DSPs
https://dsp56300.wordpress.com/
GNU General Public License v3.0
334 stars 40 forks source link

Various parameter description fixes (XT) #185

Closed mkruselj closed 2 months ago

mkruselj commented 2 months ago

Please read commit messages for both commits which list everything that was done! 🙂

dsp56300 commented 2 months ago

@mkruselj thanks a lot, awesome work! 👍

Only thing I am wondering about is how you were able to still load the plugin after removing one value from the lfoSync list. This should result in an error at startup

mkruselj commented 2 months ago

Actually have no idea, It just resulted in this over here on Windows/VST2:

image

I suppose I can reinstate how it was (Off On On Clock) and then pass it over to you folks to fix it properly? But if this is going to be fixed properly it probably makes sense to only have the unique entries in that list, right? The fix would be a separate commit anyways, so if the menu is broken in a slightly different way for the time being it might not matter much for the time being?

dsp56300 commented 2 months ago

I will check the code, it should log a warning that parameter description parsing failed but it may still load the plugin, if that is the case I will change that (and display all parsing issues as message on screen, similar to skin loading issues).

For now, a possible fix would be to leave one of the "On" entries empty, i.e. "Off", "On", "", "Clock", the dropdown will not display empty values.

We are going to implement proper value mapping soon, this will also allow to reorder entries as there are numerous requests already to sort mod dests in OsTIrus alphabetically

mkruselj commented 2 months ago

That is awesome, I was about to suggest some sort of kv pair value remapping strategies!

It would also make sense to be able to supply shorthand menu entries that would only be used when the menu is NOT clicked. For example like in Kontakt:

image

You can make the context menu entries say one thing, but the menu shows another thing after you pick an entry. I'm not sure if JUCE supports this natively or if the PopupMenu widget would have to be subclassed and then expanded with this sort of functionality.