dspiljar / mboxgrep

A tool to select email messages matching a pattern from a mailbox
https://mboxgrep.org/
GNU General Public License v2.0
2 stars 1 forks source link

Windows support, performance, passthrough mode #3

Closed giachello closed 2 months ago

giachello commented 2 months ago

Hi there. I made several changes to your code.

dspiljar commented 2 months ago

Hi Giovanni,

Many thanks for this pull request, quite amazing stuff! I will edit it before merging, however, because I am reluctant about the end-of-line sequence question, as explained here.

Best regards, Daniel

dspiljar commented 2 months ago

Hi Giovanni,

Would you be so kind and split this pull request into multiple separate ones, perhaps according to your points above, just for the sake of clarity in the commit log?

It looks good and I am ready to merge most of it, with the exception of the \r\n end-of-line sequence question, which needs a more elaborated solution (as discussed).

Thanks!

Best regards, Daniel