search

dspinellis / dgsh

Shell supporting pipelines to and from multiple processes
http://www.spinellis.gr/sw/dgsh/
Other
323 stars 22 forks source link

Update install-wrapped.sh #107

Open Gooberpatrol66 opened 6 years ago

Gooberpatrol66 commented 6 years ago

Line 52 echoes DESTDIR into wrapper scripts. When built in a sandbox, this breaks the dgsh programs after they have been moved out of the temporary install directory. Changed to fix.

dspinellis commented 6 years ago

Thank you! Could you perhaps look into the failing CI build? It could be irrelevant to your change, but I'd like to pull your change with a clean CI build.

Gooberpatrol66 commented 6 years ago

I looked at the log and I wasn't really sure what was causing the error.

dspinellis commented 6 years ago

Maybe a flakey test. I'm rerunning it.

Gooberpatrol66 commented 6 years ago

Are there any tests run inside the temporary install directory? This may have changed it from being broken while outside the temporary directory to being broken while inside the temporary directory.