Substitute /usr/local for PREFIX in search path

dspinellis / git-issue

Git-based decentralized issue management

GNU General Public License v3.0

773 stars 66 forks source link

Substitute /usr/local for PREFIX in search path #63

Closed jmtd closed 4 years ago

jmtd commented 4 years ago

When git-issue is installed vi "make install" and PREFIX is overridden from /usr/local, substitute for this in the library search path within git-issue. Fixes #61.

This uses a GNU Makefile feature (text substitution) to avoid the path separator '/' being interpreted as the substitution delimiter for sed.

dspinellis commented 4 years ago

Good idea, thank you! Please provide a single clean commit taking into account the following.

Start from the current version to avoid conflicts (no sync-docs should be required).
Avoid using sed -i and the GNU-make extension. Both are likely to fail on macOS and FreeBSD.
To avoid the make substitution specify the substitution pattern as `"s|/usr/local|$(PREFIX)|g"
To avoid -i redirect the output of sed into a local temporary file and install that one.

jmtd commented 4 years ago

@dspinellis

Good idea, thank you! Please provide a single clean commit taking into account the following.

OK, done and force-pushed. Thanks for the feedback!

jmtd commented 4 years ago

hi @dspinellis is further work required here?