search

dsrkafuu / hugo-theme-fuji

A minimal Hugo theme with nice theme color. | 一个主题色极简 Hugo 主题。
https://github.dsrkafuu.net/hugo-theme-fuji/
Apache License 2.0
368 stars 98 forks source link

fuji.scss: let the user override both the variables and the CSS rules #44

Closed Hyask closed 4 years ago

Hyask commented 4 years ago

This MR allows overriding both the SCSS variables and the SCSS rules with two different files, loaded at different stages.

dsrkafuu commented 4 years ago

@Hyask Thanks for the pull request! 😀 Since there may be people who are upgrading themes from previous versions, I thought the _custom_var.scss should be kept as _custom.scss, or just make these two all available for easy upgrading. What do you think?

Hyask commented 4 years ago

@Hyask Thanks for the pull request! grinning Since there may be people who are upgrading themes from previous versions, I thought the _custom_var.scss should be kept as _custom.scss, or just make these two all available for easy upgrading. What do you think?

Maybe the default _custom_var.scss could import the former one (_custom.scss)? That way, you don't import both, because if the user creates a _custom_var, your default file won't be read. That avoids having two custom imports at the same place in the theme.