search

dsrkafuu / hugo-theme-fuji

A minimal Hugo theme with nice theme color. | 一个主题色极简 Hugo 主题。
https://github.dsrkafuu.net/hugo-theme-fuji/
Apache License 2.0
366 stars 97 forks source link

Emphasis vs Link color #51

Closed FelixBenning closed 2 years ago

FelixBenning commented 3 years ago

I noticed that you are using the same color for links and emphasis. It is a little confusing to have some things with that color be clickable and other things which are not. Especially since "emphasised and clickable" is probably exactly the same as "only emphasised".

grafik

Not a huge issue of course

dsrkafuu commented 3 years ago

I'm considering whether or not to add an underline to the links, not sure if it will affect the overall feel of it.

FelixBenning commented 3 years ago

given how few websites use underlines for links nowadays I suspect that "it doesn't look good". But given that I am not a designer I don't know if a different color would be better or whether that would make the color palette to excited. You could of course remove the color entirely and let cursive speak for itself.

But given that you actually created a theme which "looks good" without knowing really why, I would trust your instinct better than mine.

edxu96 commented 3 years ago

I like having more coloured text, but there are already many links in my posts. Some reader might think non-clickable words are dead links. I made the following change:

Screenshot 2021-03-15 at 07 13 43

retrhelo commented 2 years ago

I suggest not using any color for emphasis, like github and many other editors do. The italic font itself is the best way to "emphasis" the text.

The change can be easily done by removing codes in assets/scss/_fuji-theme/_style.scss.

strong,
em {
  color: var(--color-secondary);
}
dsrkafuu commented 2 years ago

Modded in 253850bb1f3b0faae8472f31a28725fec8684ffa