dsrvlabs / vatz-proto

Protobuffers for VATZ Service
Apache License 2.0
2 stars 2 forks source link

Update dependabot and submodule #25

Closed xellos00 closed 1 week ago

xellos00 commented 2 weeks ago

Update dependabot and submodule

Confirm that it properly is built.

 dongyookang DK 👑   ~/ffplay/GolandProjects/xellos/vatz-proto   update_dependabot_patch_in_lib
î‚° make all  
make init
go install google.golang.org/protobuf/cmd/protoc-gen-go@latest
go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@latest
make build
 dongyookang DK 👑   ~/ffplay/GolandProjects/xellos/vatz-proto   update_dependabot_patch_in_lib ±
î‚° 
xellos00 commented 2 weeks ago

@rootwarp Sorry for the weekend review request, but could you take a look at this PR? It's addressing the following tasks:

xellos00 commented 1 week ago

LGTM.

Working on my side.

@rootwarp, just let you know that I updated rule from 2 ppl approval to 1 ppl approval to proceed for this time.