dsrvlabs / vatz

Node management integration tools in purpose of maximizing node's uptime for any protocols
https://www.dsrvlabs.com/
GNU General Public License v3.0
30 stars 15 forks source link

How to manage secret_key voting for github action #120

Closed kim201212 closed 2 years ago

kim201212 commented 2 years ago

Checklist

Please describe, what it's about or related Problem with

A clear description of what feature need to be developed or enhanced in Vatz

=> secret_key is required for github action CI. we need to discuss how to manage secret_key.

Describe the output that you are expecting for above

A clear and concise description of what you expect to happen.

=> I think github_token should be made exclusively for CI and managed.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

=> we need to create a CI bot token or put one of our tokens.

Additional context

Add any other context or screenshots about the feature request here.

xellos00 commented 2 years ago

@kim201212 Can you research which options good for secret_key to use our CI/CD and put a vote on this issue?

kim201212 commented 2 years ago

@dsrvlabs/validator

Let's vote which one we prefer for github action secret_key.


Options

  1. Using the token of the code maintainer. 👍🏽
  2. Using the token of validator@dsrvlabs.com 👎🏽
  3. Create a new user with vatz@dsrvlabs.com even for the future 👀
xellos00 commented 2 years ago

Options

  1. Using the token of the code maintainer.
  2. Using the token of validator@dsrvlabs.com

I updated your comment to ping everyone.

hqueue commented 2 years ago

@kim201212 I also like option 3.

xellos00 commented 2 years ago

@dsrvlabs/validator

Let's vote which one we prefer for github action secret_key.

Options

  1. Using the token of the code maintainer. 👍🏽
  2. Using the token of validator@dsrvlabs.com 👎🏽
  3. Create a new user with vatz@dsrvlabs.com even for the future 👀

@hqueue

  1. Git: vatz-bot, Email: vatz@dsrvlabs.com
xellos00 commented 2 years ago

@kim201212 Can you track this and manage it with @hqueue and let you roll this issue, and let me know if there's any further discussion need.

xellos00 commented 2 years ago

@kim201212 Can you track this and manage it with @hqueue and let you roll this issue, and let me know if there's any further discussion need.

@kim201212 I know you are busy, I will take this from here.

xellos00 commented 2 years ago

@hqueue Can you create a brand new vatz@dsrvlabs.com mail for VATZ secret purpose? and then I will create a new github account with this e-mail.

xellos00 commented 2 years ago

image

xellos00 commented 2 years ago

@hqueue Seems it's been created new address with vatz@dsrvlabs.com. how I would receive any email that has sent to vatz@dsrvlabs.com? Is this connected to my email?

image
hqueue commented 2 years ago

2022-08-31 Configured and being tested

Applied mail forwarding to @xellos00 from vatz@dsrvlabs.com.

We have to decide who will receive this mail. I suggest to forward all email to vatz maintainers together.

@xellos00 what do you think of it?

xellos00 commented 2 years ago

2022-08-31 Configured and being tested

Applied mail forwarding to @xellos00 from vatz@dsrvlabs.com.

We have to decide who will receive this mail. I suggest to forward all email to vatz maintainers together.

@xellos00 what do you think of it?

vatz maintainers are @rootwarp @xellos00 @hqueue

Am I correct? if so, I think it's all good

xellos00 commented 2 years ago

@hqueue

Can you register vatzDSRV to dsrv group?

image
hqueue commented 2 years ago

@xellos00 let's discuss this at tonight bi-weekly sync meeting :)

xellos00 commented 2 years ago
vatzDSRV commented 2 years ago

@hqueue @rootwarp New registration is done for VATZ-bot!!

xellos00 commented 2 years ago

We created github-action bot and will generate key and manage it within this account and close this issue.