Check golang lint automatically

dsrvlabs / vatz

Node management integration tools in purpose of maximizing node's uptime for any protocols

https://www.dsrvlabs.com/

GNU General Public License v3.0

30 stars 15 forks source link

Check golang lint automatically #196

Closed kim201212 closed 1 year ago

kim201212 commented 2 years ago

Parents: #248

What does it require to on Vatz

A clear and concise description of what you expected to happen through Ci/CD

Vatz needs to check golang lint automatically

Expected behavior

A clear and concise description of results after CI/CD implementation.

The action runs golangci-lint and reports issues from linters.

How to run

Please, Update and give simple guide to run CI/CD process with this issue.

Screenshots

If applicable, add screenshots to help explain your problem

xellos00 commented 2 years ago

@kim201212 I assume you need to proceed this issue any time soon, I think I gave you enough time to deal with.

kim201212 commented 2 years ago

I tested in https://github.com/kim201212/vatz When I run golangci-lint on GitHub action, the below error occurs


  level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/dsrvlabs/vatz-proto/plugin/v1\""
  level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/dsrvlabs/vatz-proto/plugin/v1\"\n\n"

It seems to be caused by referring to the private repo module.

xellos00 commented 1 year ago

@kim201212 Can you send PR so we can test this?

kim201212 commented 1 year ago

@kim201212 Can you send PR so we can test this?

I sent the PR (https://github.com/dsrvlabs/vatz/pull/311), Please review it 🙏