search

dss-ialh / dss-blogs

Communication portal of Data Science Studio at the Institute of Aging and Lifelong Health
GNU General Public License v3.0
1 stars 0 forks source link

posts to review (1 new) #19

Closed huttoncp closed 4 years ago

mrparker909 commented 5 years ago

Good to see new content! Is there a link to the post?

huttoncp commented 5 years ago

There should be a link in the summaries I submitted with the updates to my branch to the DSS blog. In any case, here is the link to the new one that you likely haven't seen yet:

https://craig.rbind.io/post/2019-08-06-asgr-2-0-basic-operations-and-data-structures/

huttoncp commented 5 years ago

Hmm. I haven't encountered a situation yet where I needed to use the array function, so I don't know that it should be covered directly for this audience, but I will add a brief note on it to be comprehensive. I also didn't mention time series or data.table objects... I will probably cover those later on if I do another series on data science with R.

mrparker909 commented 5 years ago

Good point! I've been using arrays a lot lately (for efficiently working with large lists of matrices), so they've been on my mind. But you're right, the tutorial doesn't need to cover every possibility.

On Wed, Aug 21, 2019 at 9:40 AM Craig Hutton notifications@github.com wrote:

Hmm. I haven't encountered a situation yet where I needed to use the array function, so I don't know that it should be covered directly for this audience, but I will add a brief note on it to be comprehensive. I also didn't mention time series or data.table objects... I will probably cover those later on if I do another series on data science with R.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/dss-ialh/dss-blogs/pull/19?email_source=notifications&email_token=AHBQGR673XGNT2VVUSFHQDTQFVVY7A5CNFSM4IMU4QAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD42KH2A#issuecomment-523543528, or mute the thread https://github.com/notifications/unsubscribe-auth/AHBQGR2V46SW6GJFYUX3Q43QFVVY7ANCNFSM4IMU4QAA .

huttoncp commented 5 years ago

OK I just updated the post to include a mention of arrays and provided a few links for those who are interested in learning more about them.

huttoncp commented 5 years ago

FYI I also added a link to a video with more information on lists since I won't be covering those until much later in the blog series.

mrparker909 commented 5 years ago

@huttoncp The post looks great, but I ran into a problem. I went to merge the pull request and realized that it is based on an old version of the site.

Could you pull the new version of the site, create the page template using page bundles (you can copy the file structure here: sample post).

Then push only those files under the content folder (none of the files generated under the public folder). Let me know if you want any help!

andkov commented 5 years ago

sorry, Craig, just noticed your email. Something is wrong with my gmail. I will revisit this on the weekend. Hope things are going well! Andriy

On Sun, Aug 18, 2019 at 9:13 PM Craig Hutton notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/dss-ialh/dss-blogs/pull/19 Commit Summary

  • 2nd blog post
  • post for review
  • new post to review

File Changes

Patch Links:

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/dss-ialh/dss-blogs/pull/19?email_source=notifications&email_token=AAT4XSMZ6MLY4MXKWZ6VLJDQFHXR5A5CNFSM4IMU4QAKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HF3WJMA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAT4XSOD2OVENC4S4IRC6YTQFHXR5ANCNFSM4IMU4QAA .

huttoncp commented 4 years ago

an additional post is now ready for review when either of you have time:

https://craig.rbind.io/post/2019-12-30-asgr-2-1-data-transformation-part-1/

huttoncp commented 4 years ago

Thanks for the feedback and catching those errors for me Matthew. I didn't realize that signif() was technically better than round() for rounding so thanks for suggesting it (which led me to look into it). I also added the suggested coverage of the "." for passing the LHS of %>% to other argument positions.

huttoncp commented 4 years ago

reopening on main branch