search

dss-web / ninjaforms-uploads-azure

Add support for offloading Ninja Forms Uploads to the Microsoft Azure cloud.
MIT License
0 stars 0 forks source link

Implement more user friendly account-definitions #2

Closed Clorith closed 3 years ago

Clorith commented 3 years ago

Currently the way to create a connection to Azure requires a rather long handcrafted string which may be easy to get wrong.

Instead I propose we change DEKODE_NINJAFORMS_AZURE_CONNECTION_STRING to a set of strings, preferably with a naming convention that suits other Azure plugins that exists in the WP ecosystem.

Let's consider using these:

The MICROSOFT_AZURE_CNAME entry may not necessarily be needed here (it is used to represent a site-specific URL that is an alias for the default Microsoft blobstorage URL, so it looks nicer and more familiar to end users).

Clorith commented 3 years ago

Perhaps this should also have a fallback, if the options are not defined as a constant, allow the declaration to be done via the File Uploads settings, like the S3 settings?

File Uploads external settings page (found under /wp-admin/admin.php?page=ninja-forms-uploads&tab=external)