search

dssg / collate

Aggregation SQL Query Builder
Other
1 stars 3 forks source link

use filter instead of case when #78

Closed potash closed 7 years ago

mbauman commented 7 years ago

Nice! Did you look at how the plan is different between the two? I think that theoretically this should allow it to be faster, regardless of the current optimizations.

codecov-io commented 7 years ago

Codecov Report

Merging #78 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   95.53%   95.55%   +0.01%     
==========================================
  Files           4        4              
  Lines         269      270       +1     
==========================================
+ Hits          257      258       +1     
  Misses         12       12
Impacted Files Coverage Δ
collate/collate.py 93.75% <100%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd6eb13...a59ac30. Read the comment docs.

mbauman commented 7 years ago

@k1aus thinks that there may be quantities for which this will not work. I'll try to get an example.

mbauman commented 7 years ago

Let's give it a shot.