search

dssg / collate

Aggregation SQL Query Builder
Other
1 stars 3 forks source link

Allow overriding of choice quoting [Resolves #81] #83

Closed thcrock closed 7 years ago

thcrock commented 7 years ago

I gave the choice quoting override a stab.

codecov-io commented 7 years ago

Codecov Report

Merging #83 into master will decrease coverage by 0.24%. The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   95.53%   95.28%   -0.25%     
==========================================
  Files           4        4              
  Lines         291      297       +6     
==========================================
+ Hits          278      283       +5     
- Misses         13       14       +1
Impacted Files Coverage Δ
collate/collate.py 93.17% <90%> (-0.3%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4acdeaa...a1d22ce. Read the comment docs.

mbauman commented 7 years ago

LGTM! Thanks for doing this.