search

dssg / collate

Aggregation SQL Query Builder
Other
1 stars 3 forks source link

Don't modify dict during iteration when shortening keys #84

Closed mbauman closed 7 years ago

mbauman commented 7 years ago

This is a simple workaround; make dict.keys() non-lazy. Should fix #82.

codecov-io commented 7 years ago

Codecov Report

Merging #84 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files           4        4           
  Lines         297      297           
=======================================
  Hits          283      283           
  Misses         14       14
Impacted Files Coverage Δ
collate/collate.py 93.17% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 36a93e2...9682010. Read the comment docs.