dssg / police-eis

DSaPP police early intervention system: using machine learning to predict adverse incidents
Other
50 stars 20 forks source link

Complete refactoring of index page, including react-table #200

Closed thcrock closed 7 years ago

thcrock commented 7 years ago

@tweddielin Can you test this out? Don't mind the large number of lines changed, most of it is the vendor reactable.js file which should be safely ignorable.

With this, the index page should be complete. I would also like to change this to be more idiomatic and use state to assemble parameters/metrics instead of the DOM, but that can wait.

I've spent some time using this and it seems to generally work, albeit with some navigation changes; the paginator is different in react-table, for instance. Let me know if any of these changes are dealbreakers, or if there are any bugs I didn't see.

tweddielin commented 7 years ago

I think the cmpd_2015 db is currently down. I'm changing to their new db and test.

tweddielin commented 7 years ago

So I change to new db and test. It's pretty awesome. I just found some small things that probably need to fix.

Otherwise, most things are good and functional.