Issue 864 py39 - Githubissues

dssg / triage

General Purpose Risk Modeling and Prediction Toolkit for Policy and Social Good Problems

Other

182 stars 61 forks source link

Issue 864 py39 #865

Closed thcrock closed 2 years ago

thcrock commented 2 years ago

Removes Python3.6 support and adds up to 3.9. Changes needed:

numpy upgrade
Removes create_autospec function call from catwalk integration test; it appears that simply passing the class name to spec_set works now, and create_autospec used in conjunction with this now breaks it.

shaycrk commented 2 years ago

Thanks @thcrock -- one quick question here: does this remove support for python 3.6 in the sense that the changes here break compatibility with 3.6 or just in the sense that we won't run unit test using 3.6 so don't guarantee that it will continue to work?

thcrock commented 2 years ago

@shaycrk this drops support for 3.6 as numpy has dropped support for it.

shaycrk commented 2 years ago

Ah, that's too bad (not a huge deal, I just happen to still be on 3.6 in some of my environments). The changes here themselves look good to me.

Do you think we should do a bigger version bump (at least minor rather than patch) in that case?