Closed ecsalomon closed 2 years ago
do we not lint? i know black
was controversial, but not even pep8?
closes #880
actually finished fiddling :)
Thanks @ecsalomon! Just took a pass through and made a couple inline comments, but I think it looks pretty good overall.
I don't think we've had a linter as far back as I remember. I'm actually not a huge fan of linters generally, but if everyone else feels strongly, I imagine we could add one so long as it's not too heavy-handed.
@ecsalomon -- I just merged #877, so we should be good to incorporate this branch as well when you have a chance to do the updates and resolve the merge conflicts. Thanks!
Latest changes were written and tested in 3.10 in anticipation of #893
Thanks @ecsalomon -- generally looks good to me, but added a couple small notes. Also, seems like several .swp
files got added to the commit here. Maybe those should be added to the .gitignore
?
Looks good to me -- I'll go ahead and merge it!
Maintaining a large project with multiple experiment files can become burdensome when the same cohort or label queries are used in multiple experiments. This is made easier by allowing users to include filenames in place of code in the config. Triage loads the query into the config before hashing components or the experiment to ensure that the query itself is versioned, rather than the filepath.
I haven't tried to update dirty duck but would be happy to add that to this PR.
Wasn't sure where to plop the new utility function because
experiments
doesn't have its own utils?