Somewhat urgent bugfix -- currently, when omitting the cohort_config section of a triage_config, it gets filled in with a default query that selects all entity_id values from the feature table from objects. However, this default behavior no longer applies because this section of the config is now optional.
To fix this issue, this pull request does three things:
Remove the fill_cohort_config_missing default function (and associated test)
Allows for passing the CohortConfigValidator if the cohort_config section is omitted
Avoids inserting cohort records for as_of_date values that already exist in the cohort table when defining the cohort based on the labels table (note directly related to the bugfix, but avoids potential inconsistencies by mimicking the existing behavior when inserting from a query with replace=False)
Somewhat urgent bugfix -- currently, when omitting the
cohort_configsection of atriage_config, it gets filled in with a default query that selects allentity_idvalues from the feature table from objects. However, this default behavior no longer applies because this section of the config is now optional.To fix this issue, this pull request does three things:
fill_cohort_config_missingdefault function (and associated test)CohortConfigValidatorif thecohort_configsection is omittedas_of_datevalues that already exist in the cohort table when defining the cohort based on the labels table (note directly related to the bugfix, but avoids potential inconsistencies by mimicking the existing behavior when inserting from a query withreplace=False)