Separate testing and main URLs

thcrock commented 7 years ago

Some rearranging to support a testing URL with minimal code duplication has been done here. This is so we can create new charts and arrange them on a page without touching the main page.

I realized that the naming of 'ModelDashboard' component was a bit misleading, and needed to be changed. It really seems to just be the component that houses our charts, so I renamed it ModelCharts. There is also a ModelChartsTesting to contain the testing graph layout.
The current App component had quite a bit of logic, which has been moved to a new, hopefully more appropriately-named ModelDashboard component. This new component receives a reference to a charts class (either ModelCharts or ModelChartsTesting) and renders it.
There are now App and AppTesting components which render the ModelDashboard with a reference to the desired charting class. These are mounted at the former / and new /testing urls, respectively.

tweddielin commented 7 years ago

Looks good to me. Just need to resolve conflicts and we're good to merge.

codecov-io commented 7 years ago

Current coverage is 75.88% (diff: 100%)

Merging #24 into master will increase coverage by 2.31%

@@             master        #24   diff @@
==========================================
  Files             4          4          
  Lines           140        141     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            103        107     +4   
+ Misses           37         34     -3   
  Partials          0          0

Powered by Codecov. Last update 018670c...83100ed

dssg / tyra

Separate testing and main URLs #24

Current coverage is 75.88% (diff: 100%)