dssg / tyra

Prediction model evaluation

Other

4 stars 1 forks source link

Big Graph for selecting models #45

Closed tweddielin closed 7 years ago

tweddielin commented 7 years ago

Two components are related to this PR, model-selectgraph and model-biggraph. model-selectgraph component is just to render the Highcharts graph and model-biggraph includes other features to interact with the Highcharts graph, such as the scroll-down menu, and there will be more.

Add big graph for model selecting using Highcharts.js
A scroll-down menu to choose how many curves to be shown
Block add-button and x-button for now, but we can always add it back which I made a render function for it.
Hide the previous table for model selecting.

codecov-io commented 7 years ago

Codecov Report

Merging #45 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #45   +/-   ##
======================================
  Coverage    75.8%   75.8%           
======================================
  Files           5       5           
  Lines         281     281           
======================================
  Hits          213     213           
  Misses         68      68

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a530a32...7d5b21e. Read the comment docs.

tweddielin commented 7 years ago

Add componentWillUnmount function to model-selectgraph in order to get rid of the warning "setState(...): Can only update a mounted or mounting component" when you hit the back-to-search button.
Remove console.log for sanity checks.
Fix lots of styling issues. Forgive me for my unfamiliarity with js ES5/ES6 styling.

thcrock commented 7 years ago

Joe has a request: remove the horizontal grid lines. With that and removing the fake data, I think this can get merged.