dssg / tyra

Prediction model evaluation
Other
4 stars 1 forks source link

Problem with capital feature names in the feature distribution graph #74

Open k1aus opened 7 years ago

k1aus commented 7 years ago

Eg the query should be:

SELECT
  "ir_id_P1Y_IncidentsOfType_complaint_sum",
  "officer_id",
  label_value
FROM "historical_features_daily"."ir_aggregation" f
  JOIN results.predictions p ON f.officer_id=p.entity_id
WHERE model_id=493
      AND p.as_of_date = '2015-08-01 00:00:00'

buth the query run is:

SELECT
  "ir_id_p1y_incidentsoftype_complaint_sum",
  "officer_id",
  label_value
FROM "historical_features_daily"."ir_aggregation" f
  JOIN results.predictions p ON f.officer_id=p.entity_id
WHERE model_id=493
      AND p.as_of_date = '2015-08-01 00:00:00'

it is correct for the test set but not for the training

tweddielin commented 7 years ago

@k1aus So I checked the current version of query.py, it doesn't seem to have this issue. I might give you an old output.js file.