search

dssg / tyra

Prediction model evaluation
Other
4 stars 1 forks source link

Remove unnecessary dependencies in requirements.txt #83

Closed nanounanue closed 6 years ago

nanounanue commented 7 years ago

For example:

https://github.com/dssg/tyra/blob/eedcbe1cdc210499518f6e8d4efae7005a9d8c29/requirements.txt#L8-L10

Also, are pandas and testing.postgresql needed?

And these should be moved to requirements-dev.txt

https://github.com/dssg/tyra/blob/eedcbe1cdc210499518f6e8d4efae7005a9d8c29/requirements.txt#L13-L15

tweddielin commented 7 years ago

@nanounanue scipy is not currently using, but it's a dependency of scikit-learn. pandas, numpy and scikit-learn are actually needed for doing some light-weight computation as well as testing.postgresql used in testing. Functions using those packages will be put in a new utils module in the future. I'll move testing.postgresql to requirements-dev.txt too.