search

dstackai / dstack

dstack is an easy-to-use and flexible container orchestrator for running AI workloads in any cloud or data center.
https://dstack.ai
Mozilla Public License 2.0
1.22k stars 90 forks source link

Rename some of the YAML properties to shorter names #1154

Open peterschmidt85 opened 2 months ago

peterschmidt85 commented 2 months ago
  1. spot_policy: spot|on-demand|auto -> spot: true|false|auto
  2. retry_policy: {retry: true|false, duration: int|str} -> retry_duration: int|str|off
  3. creation_policy: create|reuse|reuse-or-create -> reuse: false|true|auto
  4. termination_policy: dont-destroy|destroy-after-idle & termination_idle_time: int|str -> idle_duration: int|str|off
  5. pool_name: str -> pool: str
r4victor commented 2 months ago

Looks good overall. Some notes:

  1. We're going to introduce new retry policies in #1200 so retry_duration alone is not sufficient. Let's do not touch retry_policy in this issue.
  2. Regarding creation_policy, we don't have creation_policy: create. The addition of new policy should be discussed outside of renaming issue. Also, it's unclear what reuse: false|true|auto means. reuse: true may be misleading since it doesn't simply allows reuse but forces it. creation_policy: reuse|reuse-or-create is more clear. I'm against renaming this particular field as suggested.
r4victor commented 1 month ago

retry_policy renamed in #1200

peterschmidt85 commented 6 days ago

This issue is stale because it has been open for 30 days with no activity.