search

dstansby / pfsspy

Potential Field Source Surface model package for Python
https://pfsspy.readthedocs.io/
Other
41 stars 18 forks source link

pfsspy.Input.__init__() missing dtime support in master branch #149

Closed STBadman closed 4 years ago

STBadman commented 4 years ago

I cloned pfsspy from the github landing page (master branch) and found the dtime keyword appears to be missing from the Input class init() function . Seems an older version of it may have propagated into the master branch? No problems in the release versions.

dstansby commented 4 years ago

Yes, this is because I'm about to break everything in 0.5.0, to force inputs to be full on sunpy Map objects instead of numpy arrays that are assumed to be in Carrington coordinates. This will make plotting better, make validating the input easier (e.g. checking that the latitude bins are spaced in sin(lat)), and generally encourage people to use proper Map objects which have proper FITS coordinate system information in them. It also means one can now specify tracing seeds as coordinate aware astropy SkyCoord objects, which can be automatically transformed into the frame of the inputted map.

I've put more info here: https://pfsspy.readthedocs.io/en/latest/changes.html (the latest bit of the URL means docs built from the master branch). Would be super interested in any feedback on this though!