search

dstark5 / Openlib

An Open source app to download and read books from shadow library (Anna’s Archive)
GNU General Public License v3.0
913 stars 45 forks source link

versionCode not increased? #36

Closed IzzySoft closed 8 months ago

IzzySoft commented 8 months ago

Looks like you forgot to increase versionCode with each release. As this is what Android uses to tell versions apart, nobody received any update notification (so some might still sit on an old release, unaware of any updates being available). It is currently still set to 1 (the part following the +). Can you please take care to increase it with each future release? Thanks in advance!

dstark5 commented 8 months ago

Thank you bro😊 Will sure update the version on updates👍

IzzySoft commented 8 months ago

Completed where?

version: 1.0.3+1

it is still +1 where it instead should at least be +4 now (there are 4 releases already).

dstark5 commented 8 months ago

Isn't build number optional or should I have to define it If it's necessary then you are right I should update it to +4 Bro

IzzySoft commented 8 months ago

versionCode is what Android uses internally to tell versions apart. So <applicationId>_<versionName> is a unique identifier for a specific version of an app. As applicationId identifies the app and thus cannot be changed, not changing versionName means a new release overwrites the previous one in the repo – and nobody who's installed the app will ever receive any update notification (as to Android, nothing changed: the unique identifier is still the same).

So yes, you should increase the integer following the + with each release you make.

dstark5 commented 8 months ago

Okay bro I will update versioncode Should I update now or in the next release

IzzySoft commented 8 months ago

Maybe update it in your pubspec.yaml now so you cannot forget it – and have it take effect with the next release then, as the current release was already pulled? I'll leave that decision to you. As long as it's fixed with the next release :wink: