search

dstark5 / Openlib

An Open source app to download and read books from shadow library (Anna’s Archive)
GNU General Public License v3.0
1.19k stars 62 forks source link

View for non mobile platforms #6

Closed bipinkrish closed 1 year ago

bipinkrish commented 1 year ago

Option to view PDF on Linux and Windows with system's default viewer (Temporary solution for viewing) Database-Factory fix for Linux and Windows

dstark5 commented 1 year ago

Reviewed the changes you made and approved the PR

dstark5 commented 1 year ago

In main.dart The following check should be added . if (Platform.isWindows || Platform.isLinux || Platform.isMacOS) { sqfliteFfiInit(); databaseFactory = databaseFactoryFfi; }

Without this code the mobile version of app gets crash

bipinkrish commented 1 year ago

Well i didn't noticed it after checking it for Linux, sorry

bipinkrish commented 1 year ago

Well for your other question, i don't have physical mac but i can build it with github actions or other services but without apple developer account and signing the app with it, it can't be installed on any devices

dstark5 commented 1 year ago

Well i didn't noticed it after checking it for Linux, sorry

Thats Okay

dstark5 commented 1 year ago

Well for your other question, I don't have physical Mac but i can build it with GitHub Actions or other services but without apple developer account and signing the app it can't be installed on any devices

Okay,While you develop for linux also check for android