dstat-real / dstat

Versatile resource statistics tool (the real one, not the Red Hat clone)
GNU General Public License v2.0
1.34k stars 330 forks source link

mysql5 plugins not working properly (not showing rates) #43

Closed do11 closed 10 years ago

do11 commented 11 years ago

You have included some mysql plugins from lefred@inuits.be (this e-mail address is dead) into the Dstat 0.7.2 distribution, but in fact they are flawed and useless. For example dstat_mysql5_cmds.py doesn't show rate value of its variables (for example sel/Com_select), but show three major digits stripped of counter absolute value. For example:

[root@db dstat]# dstat --mysql5-cmds ------mysql5-cmds------ sel ins upd del 83 5 12 3 376 23379 52652 12796 376 23379 52652 12796 376 23379 52652 12796 376 23379 52652 12796 376 23379 52652 12796 376 23379 52652 12796 376 23379 52652 12796^C

Note that since second line values don't change. And in fact these values are even wrong, becasue "376" is meaningless number. If I change in /usr/share/dstat/dstat_mysql5_cmds.py self.width= from 5 to 11 output is like this:

[root@db dstat]# dstat --mysql5-cmds ------------------mysql5-cmds------------------ sel ins upd del 83 5 12 3 375980511 23379218 52652264 12796384 375980525 23379221 52652267 12796385 375980536 23379221 52652268 12796385 375980575 23379223 52652279 12796388 375980604 23379227 52652284 12796389^C

This is more meaningful, but still not very useful, as rate value would be more appropriate and expected (similar to dstat output model of other statistics.)

What values are in the first line (where '83') I don't even understand.

Currently all mysql plugins in dstat 0.7.2 is like this.

[root@db dstat]# dstat --mysql5-io -mysql5-io- recv sent 96.9k 1706k 421G 7413G 421G 7413G 421G 7413G 421G 7413G^C ...and same value continue on many lines. Which is not i/o rate at all. And first line values is obscure again.

dagwieers commented 11 years ago

I accept patches.

do11 commented 11 years ago

Good luck in that.

nkhare commented 10 years ago

It looks this has been fixed with commit-id fe5f91621f9c37671f359a75b40f4d6c29dd82e6

dagwieers commented 10 years ago

Thanks ! That's why I often ask people to try the master branch before reporting issues.