search

dstein64 / nvim-scrollview

A Neovim plugin that displays interactive vertical scrollbars and signs.
MIT License
517 stars 9 forks source link

Compatibility with 0.10 extmark sign #126

Closed ofseed closed 6 months ago

ofseed commented 6 months ago

After https://github.com/neovim/neovim/pull/26193 , the internal implementation of the diagnostic signs changed to the new extmark-based sign, sign_getdefine will no longer work for diagnostic signs.

I see the call of sign_getdefine is implemented by vimscript, which I am not familiar with. Refer to https://github.com/nvim-neo-tree/neo-tree.nvim/pull/1265/files .

dstein64 commented 6 months ago

Thanks for letting me know @ofseed. I updated the code in b67dcc178ba4cac1858512e5ce2bd90e16e74c43. Does that fix the issue for you?

ofseed commented 6 months ago

Yes, thanks a lot.