search

dsteinkopf / backup-all-mysql

Docker image to do automatic backups of a mysql DB.
https://nerdblog.steinkopf.net/2017/04/backup-all-mysql-docker-image-fuer-einfaches-backup/
GNU General Public License v2.0
14 stars 8 forks source link

move --lock-tables before other opts #14

Closed thib3113 closed 5 years ago

thib3113 commented 5 years ago

--skip-lock-tables need to be adds after --lock-tables, so reverte --lock-tables in front of the other other arguments

fixes #13

dsteinkopf commented 5 years ago

After thinking a bit longer about this idea I am not quite sure if --skip-opt (see here) will reverse the effect of --lock-tables if it comes after it - or if it only does not implicitly add the options. I think the latter is the case so everything should be ok.

But how do we confirm that tables are in fact locked?

thib3113 commented 5 years ago

But how do we confirm that tables are in fact locked? no idea sorry :/ .

I'm not really a good dB admin 😂 .