search

dsteinkopf / backup-all-mysql

Docker image to do automatic backups of a mysql DB.
https://nerdblog.steinkopf.net/2017/04/backup-all-mysql-docker-image-fuer-einfaches-backup/
GNU General Public License v2.0
14 stars 8 forks source link

For free use #15

Closed Rupreht closed 3 years ago

Rupreht commented 5 years ago
dsteinkopf commented 5 years ago

Thank you very much for this contribution. I will have a deeper look at this at the weekend. To help me a bit: Could you give me a short explanation of why this fix is necessary?

thib3113 commented 3 years ago

@dsteinkopf about the diff with MYSQL_ENV_MYSQL_ROOT_PASSWORD_FILE, I just check the code, and I think this is just a misspelling in the readme ? no ? ( it is MYSQL_PASSWORD_FILE ? ) . And finally the change in loop is not necessary, but needed in the readme ?

dsteinkopf commented 3 years ago

To be honest, I am not sure about this MYSQL_ENV_MYSQL_ROOT_PASSWORD_FILE. I just remember some Docker mechanism that automatically created and filled this kind of variables. I don't know if it is still useful for anyone to support this. As this script definitely is not very cleaned up or good code - but is still working well - I tend to just leave it and merge this PR.

thib3113 commented 3 years ago

@dsteinkopf did you have more informations about this "mechanism" ?

Or you are speaking about the function file_env https://github.com/dsteinkopf/backup-all-mysql/blob/master/loop.sh#L9 , and when you call it the env name : https://github.com/dsteinkopf/backup-all-mysql/blob/master/loop.sh#L27 .

That will : read the content of the file MYSQL_PASSWORD_FILEand set it in the envMYSQL_PASSWORD` ?

dsteinkopf commented 3 years ago

@dsteinkopf did you have more informations about this "mechanism" ?

No. But googleing for MYSQL_ENV_MYSQL_ROOT_PASSWORD gives some results...

Or you are speaking about the function...

No. But thank you for your ideas and your help.