search

dsteinkopf / backup-all-mysql

Docker image to do automatic backups of a mysql DB.
https://nerdblog.steinkopf.net/2017/04/backup-all-mysql-docker-image-fuer-einfaches-backup/
GNU General Public License v2.0
14 stars 8 forks source link

incremental save #16

Open mkrierQape opened 5 years ago

mkrierQape commented 5 years ago

Hello,

it possible to modify the script for incremental save ? currently every time is script is running its deleting previous save, can you make a options for saving the file with the current date ? Something like : $DBDUMPSDIR/mysqldump_$db_YYYY_MM_DD_HH_MM.sql.bz2

Thank

dsteinkopf commented 5 years ago

Yes, this would be possible, of course. The reason why I didn't do this is the "unix idea of orthogonal tools": backup-all-mysql only does the dumps on a regular basis. A different tool (backuppc in my case) moves the backup files to a different media and does versioning. - With that in mind, it would not be a good idea to create a different filename for every backup.

If you really would like to implement such a filename scheme (as suggested by you), feel free to implement that and send a PR. But please keep an option to always get the same filename - just as it's currently done. - Maybe a configurable filename pattern with a default that's the current filename ("mysqldump.sql").

(Sorry for answering so late - I was on holiday and then I "forgot" this notification email.)

Jogai commented 4 years ago

Reminder for when I get back to this (or for anyone that wants to do this ;),

mkdir -p "${date +%Y/%m/%d/%H/%M/%S}"