Several security improvements

dsteinkopf / backup-all-mysql

Docker image to do automatic backups of a mysql DB.

GNU General Public License v2.0

14 stars 8 forks source link

Closed thib3113 closed 5 years ago

thib3113 commented 5 years ago

Allow to set ENV by secrets / file content:
allowing _FILE suffix for secrets use and/or file containing sensitive data ( like password )
update documentation
remove set -x ( printing secrets )
store username / password / host in .my.cnf, to remove warning about password in command line

thib3113 commented 5 years ago

Sorry for the indentation problem .

About the 3PR, it's because I'm not sure you are OK with other PR . So I'm just adding a pull request, and up to you to merge / discuss / or not .

About tests, I've created my automated build : https://hub.docker.com/r/thib3113/backup-all-mysql/ And testing on my docker container, by checking logs .

dsteinkopf commented 5 years ago

the indentation problem (not worth discussing much about it) was to remove one level - now you added another one :-) - I'll finish for today (sorry).

3 PRs are fine - I am just a bit confused about the inter-dependencies.

thib3113 commented 5 years ago

Sorry, really hard to see levels on github "conversation view" :/ .

No problem for the moment . It's not urgent, for the moment, I've my image for the moment .

About the PR, I don't know, maybe because my 2 PR, are based on my master branch, so in the PR, the commits from the master are duplicated :/ .