Hex blob - Githubissues

dsteinkopf / backup-all-mysql

Docker image to do automatic backups of a mysql DB.

https://nerdblog.steinkopf.net/2017/04/backup-all-mysql-docker-image-fuer-einfaches-backup/

GNU General Public License v2.0

14 stars 8 forks source link

Hex blob #6

Closed thib3113 closed 5 years ago

thib3113 commented 5 years ago

This PR just add --hex-blob in the default list of options .

I'm not an expert, so I didn't know if it's a good idea or not . But Sometimes we try to save database with binary data ( like the wordpress plugin "wordfence" ), and this database can't be restored without this argument .

So, someone doesn't know this, will get a really bad suprise :/

dsteinkopf commented 5 years ago

Could you please review this PR now (after merging #4):

We got a (simple) conflict (because you did the same indent changed independently in the branches)
I see the same changes as in #4 AND (as far as I can see) in #5

But maybe we first finish #5 ...

dsteinkopf commented 5 years ago

My notes abount --hex-blob:

You can add additional mysqldump options via env MYSQLDUMP_ADD_OPTS (see readme). So is this change (= only adding an option to mysqldump) really necessary?
I also use this script to dump a wordpress installation using the wordfence plugin. I also used the dump to restore the db successfully several times.

So I would prefer to not add this option for every user.

Any other thoughts?

thib3113 commented 5 years ago

I also use this script to dump a wordpress installation using the wordfence plugin. I also used the dump to restore the db successfully several times.

Yes, me too, but one time, I get a sql file, containing some binary string, and this string crash the restore process, and if open with mysql workbench, it use more than 28Go of ram ....

So in my opinion, this option can't do bad things (not an mysql expert, so I'm not 100% sure), but can save the life some times ( it's why I do this change ) .