search

dsteinkopf / backup-all-mysql

Docker image to do automatic backups of a mysql DB.
https://nerdblog.steinkopf.net/2017/04/backup-all-mysql-docker-image-fuer-einfaches-backup/
GNU General Public License v2.0
14 stars 8 forks source link

replace tabs by 8 spaces #9

Closed dsteinkopf closed 5 years ago

dsteinkopf commented 5 years ago

I did this via the command line tool expand -t 8 backup-all-mysql.sh. And I chose 8 to not destroy the existing indentation done mixed by spaces and tabs.

dsteinkopf commented 5 years ago

FYI: see expand_tabs.sh

dsteinkopf commented 5 years ago

@thib3113 feel free to add a PR adding --hex-blob now! :-)

thib3113 commented 5 years ago

Hum, If we want to be perfect with tabs, I think we need to do a little more than just convert tab to 8 spaces . Because, sometimes you use 4 spaces, sometimes a tab + 4 spaces (maybe me for this), sometimes 4 spaces .

dsteinkopf commented 5 years ago

Yes, you're completely right. This was the first step I wanted to invest in this "tiny unimportant" project.