search

dstl / Stone-Soup

A software project to provide the target tracking community with a framework for the development and testing of tracking algorithms.
https://stonesoup.rtfd.io
MIT License
384 stars 126 forks source link

Implementation of Loopy Belief Propagation (LBP) #1022

Closed marcelh71 closed 2 weeks ago

marcelh71 commented 1 month ago

This pull request is the LBP algorithm of Williams and Lau (2014). This is an efficient mechanism for calculating the marginal association probabilities when performing soft data association (e.g. as in the JPDA filter).

sdhiscocks commented 2 weeks ago

@marcelh71 Hope it's okay, I pushed some changes to get flake8/test issues resolved, as they were mainly caused by my suggested changes.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 91.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.55%. Comparing base (4111cb7) to head (0c341f4). Report is 48 commits behind head on main.

Files Patch % Lines
stonesoup/dataassociator/probability.py 91.66% 1 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1022 +/- ## ========================================== - Coverage 93.56% 93.55% -0.02% ========================================== Files 202 202 Lines 12985 13054 +69 Branches 2649 2668 +19 ========================================== + Hits 12150 12213 +63 - Misses 591 593 +2 - Partials 244 248 +4 ``` | [Flag](https://app.codecov.io/gh/dstl/Stone-Soup/pull/1022/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dstl) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/dstl/Stone-Soup/pull/1022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dstl) | `65.96% <12.50%> (-0.34%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/dstl/Stone-Soup/pull/1022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dstl) | `89.19% <91.66%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dstl#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marcelh71 commented 2 weeks ago

Hi Steve,That’s absolutely fine. Many thanks for resolving the issues.Best wishes,Marcel.