search

dstl / Stone-Soup

A software project to provide the target tracking community with a framework for the development and testing of tracking algorithms.
https://stonesoup.rtfd.io
MIT License
406 stars 134 forks source link

Fix Inverse Function in CartesianToElevationBearingRangeRate #1024

Closed gawebb-dstl closed 3 months ago

gawebb-dstl commented 4 months ago

Fix CartesianToElevationBearingRangeRate.inverse_function. Current tests didn't find the problem as the state to measure was on the x-axis (phi == theta == 0). New tests have been added which will fail on the old implementation.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.55%. Comparing base (13f7578) to head (5db9226). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1024 +/- ## ========================================== - Coverage 93.58% 93.55% -0.04% ========================================== Files 203 203 Lines 13115 13113 -2 Branches 2678 2678 ========================================== - Hits 12274 12268 -6 - Misses 591 594 +3 - Partials 250 251 +1 ``` | [Flag](https://app.codecov.io/gh/dstl/Stone-Soup/pull/1024/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dstl) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/dstl/Stone-Soup/pull/1024/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dstl) | `65.93% <100.00%> (+<0.01%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/dstl/Stone-Soup/pull/1024/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dstl) | `89.19% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dstl#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gawebb-dstl commented 4 months ago

CartesianToElevationBearingRangeRate.inverse_function has been mentioned in several places