search

dstndstn / astrometry.net

Astrometry.net -- automatic recognition of astronomical images
http://astrometry.net
Other
664 stars 186 forks source link

qfits_card.c:238]: (style) Array index 'i' is used before limits check. #119

Closed dcb314 closed 6 years ago

dcb314 commented 6 years ago

Source code is

while (line[i]!='=' && i<80) i++;

Plenty of duplicates in the same file:

[qfits_card.c:308]: (style) Array index 'i' is used before limits check. [qfits_card.c:316]: (style) Array index 'i' is used before limits check. [qfits_card.c:399]: (style) Array index 'i' is used before limits check. [qfits_card.c:238]: (style) Array index 'i' is used before limits check. [qfits_card.c:308]: (style) Array index 'i' is used before limits check. [qfits_card.c:316]: (style) Array index 'i' is used before limits check. [qfits_card.c:399]: (style) Array index 'i' is used before limits check.

dstndstn commented 6 years ago

What tool are you using here?

I'm not sure, but it's possible that these are not actually problems due to higher-level guarantees (eg, calling code knows there is an '=' in the string).

dcb314 commented 6 years ago

What tool are you using here?

cppcheck, a static analyser for C and C++

dstndstn commented 6 years ago

Thank you -- fixed in 7b732f5a