search

dstndstn / astrometry.net

Astrometry.net -- automatic recognition of astronomical images
http://astrometry.net
Other
679 stars 189 forks source link

Bring nova into the Python 3 world #179

Closed bnavigator closed 4 years ago

bnavigator commented 4 years ago

I have to migrate our local nova server and want to get rid of Python 2. From #148 I gathered that the solver should be ready for Python 3, but in my attempt the net part kept failing.

I think I have fixed most of the obvious code lines specific to python 2 such as the transition of urllib and some str vs byte TypeErrors when dealing with file i/o streams.

I have not attained full functionality of my local nova installation yet, but at least I do not get any exceptions thrown at my by the webserver anymore. Don't know yet if the remaining issues have to do with Python 3 or other parts of the setup.

bnavigator commented 4 years ago

I don't think the Travis CI fail has anything to do with the PR

dstndstn commented 4 years ago

This is great -- you're right, the travis failure is due to an error building the dependency 'fitsio', which then trickles down to make tests fail. I should pin fitsio to a specific version...

Let me know if/when you get stuck and I can take a look.

For what it's worth, on the nova site we're running django 1.11.2 (I should upgrade to 1.11.28).

bnavigator commented 4 years ago

I think I made some good progress. I'll let our users test further on the local nova, but my rudimentary tests of submitting and viewing files seems to work. Please have a look.

bnavigator commented 4 years ago

Update: Our users report that the local nova installation running on FreeBSD with Python 3.7 works as expected.

dstndstn commented 4 years ago

Thanks for this! Will try to take a look, test and merge today.

dstndstn commented 4 years ago

hey, sorry for my delay on this. Just testing it in our supernova.astrometry.net testbed. All looks good so far...

dstndstn commented 4 years ago

Now live at nova.astrometry.net -- thank you again for this!!