dstndstn / astrometry.net

Astrometry.net -- automatic recognition of astronomical images
http://astrometry.net
Other
661 stars 185 forks source link

Add Github CI action to build the project automatically #217

Open hrj opened 3 years ago

hrj commented 3 years ago

Adding this single file will automatically run a build via Github Actions.

Whenever a Pull Request is made, the action will check and inform if the build is failing.

(I think actions are enabled by default, but if they aren't, you can enable them in the Settings for this repository)

hrj commented 3 years ago

I have kept the workflow simple in this PR. It is also possible to run tests automatically, and to do this on multiple platforms. If you are interested, I can try to make a more elaborate action in a follow up PR.

hrj commented 3 years ago

Oh oops.. I just noticed you have Circle CI enabled on this repo! The PRs didn't have any checks on them, so I assumed that there is no CI.

Sorry for the spam!

(I do think Github Actions might be more convenient though since they are integrated into the Github UI)

dstndstn commented 3 years ago

Hi, Thanks for this! Would you be willing to expand this to install all the dependencies and run the tests, eg as implemented in https://github.com/dstndstn/astrometry.net/blob/master/.circleci/config.yml#L47 ?

hrj commented 3 years ago

I tried expanding the tests. On Ubuntu 20.04, all goes well.

But Ubuntu 18.04 and CentOS are challenging, mainly because of python 3.x situation. Too many complex dependencies.

My many attempts (in a different branch): https://github.com/UprootStaging/astrometry.net/actions