dstndstn / astrometry.net

Astrometry.net -- automatic recognition of astronomical images
http://astrometry.net
Other
650 stars 184 forks source link

[0.88] astrometry.net doesn't compile on 32-bit platforms #250

Closed olebole closed 2 years ago

olebole commented 2 years ago

I am in the process of packaging astrometry.net for Debian/Ubuntu. One problem I found is that it has some incompatibility with 32-bit code (x86). From the build log:

gcc -g -O2 -ffile-prefix-map=/builds/debian-astro-team/astrometry.net/debian/output/source_dir=. -fstack-protector-strong -Wformat -Werror=format-security -g -Wall -ffinite-math-only -fno-signaling-nans -pthread -O3 -fomit-frame-pointer -DNDEBUG -fpic -fPIC -Winline -I../include -I../include/astrometry -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DAN_GIT_REVISION='"0.88"' -DAN_GIT_DATE='"Sat_Jan_8_15:27:25_2022_-0500"' -DAN_GIT_URL='"https://github.com/dstndstn/astrometry.net"' -DWCSLIB_EXISTS -I../include -I../include/astrometry -I../include -I../include/astrometry  -I/usr/include/wcslib -I../include -I../include/astrometry  -I/usr/include/wcslib -Wdate-time -D_FORTIFY_SOURCE=2  -c -o kdint_lll.o kdint_lll.c
In file included from kdint_lll.c:11:
kdint_ttype_l.h:9:9: error: '__int128' is not supported on this target
    9 | typedef __int128           int128_t;
      |         ^~~~~~~~
kdint_ttype_l.h:10:18: error: '__int128' is not supported on this target
   10 | typedef unsigned __int128 uint128_t;
      |                  ^~~~~~~~
make[3]: *** [<builtin>: kdint_lll.o] Error 1

Full build log here. That is new in version 0.88; 0.85 compiled well.

dstndstn commented 2 years ago

Hi Ole,

Thank you for your packaging efforts and the bug report!

I think I have a fix for this in main: https://github.com/dstndstn/astrometry.net/commit/968113ce8024f0057cfc4b32d424baa1fdf33659

If that works for you, I can cut a 0.89 release.

Thanks!

olebole commented 2 years ago

Hi Dustin,

Thank you for the quick fix! I can confirm that it now compiles well on all our platforms, and a test with a small input file works as expected.

Best

Ole

dstndstn commented 2 years ago

Hi Ole,

Great! I just cut the 0.89 release for you. Of course let me know if you see any more issues!

cheers, --dustin

laheller commented 2 years ago

@dstndstn

I had the same error when I tried to build for the Android armv7a (32bit) platform but your commit fixed it! Thanks for that.