dstndstn / astrometry.net

Astrometry.net -- automatic recognition of astronomical images
http://astrometry.net
Other
666 stars 187 forks source link

Web client example doesn't return finished results #263

Closed alexw-im closed 2 years ago

alexw-im commented 2 years ago

I'm only just beginning to use the client example so perhaps I'm misunderstanding the intent here. I believe the purpose of the section below is to poll status for the submission ID in question until it's been processed into a job ID, which results will eventually be associated with.

I think lines 404/405 should be replaced with 406-409? I believe 406 is unreachable as written, and this is why client.py never actually returns any results for me. I'm not certain it's the only reason, as the code generally prints lots of stuff over and over and I haven't fully wrapped my head around it yet. https://github.com/dstndstn/astrometry.net/blob/fafce3ff1f97186cf912639cd788375b97e019bc/net/client/client.py#L398-L410

alexw-im commented 2 years ago

Nevermind - the logic isn't super clear to me but it does actually work as-written. For some reason "jobs" just ended up with jobs[0]=none in my test.