dstndstn / astrometry.net

Astrometry.net -- automatic recognition of astronomical images
http://astrometry.net
Other
650 stars 184 forks source link

Python 3.12 build error #286

Closed juliotux closed 2 months ago

juliotux commented 9 months ago

astrometry.net is currently not compatible with Python 3.12, due to the deprecation of distutils PEP 632. So, the conda-forge package for astrometry.net cannot be merged (see build status).

An alternative is to migrate to setuptools package.

mattiaverga commented 7 months ago

This is probably fixed by https://github.com/dstndstn/astrometry.net/commit/7fff04d4b9f2e8bd0a2b2b567541a543a7a733dd waiting for a new release.

BTW, in Fedora 39 with Python 3.12 astrometry 0.94 builds fine, but we're starting to see failures with Python 3.13 prerelease.

juliotux commented 7 months ago

I don't think that 7fff04d currently fixes the problem. A quick search in the code shows distutils is yet being used in 10 files.

mattiaverga commented 5 months ago

In #289 I have removed all remaining calls to numpy.distutils. Other distutils calls can still work by ensuring setuptools is installed in the build environment. That's only a quick fix, though, as astrometry.net should migrate to a more modern build system.

sassy-asjp commented 5 months ago

Is there any reason blocking the migration to setuptools? It looks pretty straightforward to me and I could probably poke around at doing it some time if no one else is already working on it.

dstndstn commented 5 months ago

Some of the modules are built using swig, and they need to get library paths from the Makefile... so go ahead, if you can manage that need.

sassy-asjp commented 4 months ago

@juliotux I opened merge request #293 to hopefully fix this issue. Could you check whether it works for you?

juliotux commented 4 months ago

@sassy-asjp your review is installing fine on Python 3.12

oldherl commented 2 months ago

Could you please tag a new release to include the fix for Python 3.12?

dstndstn commented 2 months ago

Done, https://github.com/dstndstn/astrometry.net/releases/tag/0.95