search

dstndstn / astrometry.net

Astrometry.net -- automatic recognition of astronomical images
http://astrometry.net
Other
666 stars 187 forks source link

net: Replace deprecated PickleSerializer #292

Closed XePeleato closed 8 months ago

XePeleato commented 8 months ago

Django 5.x has finally removed PickleSerializer (https://github.com/django/django/pull/15139).

JSONSerializer is the default serializer now, and with Django 5.0 released Dec 4th, the code wouldn't work anymore for me.

dstndstn commented 8 months ago

Thanks for looking at this!

According to the comment on the line above, we were using the Pickle serializer because of some issue with the JSON serializer when handling some OpenID types. Were you able to confirm that the JSON serializer now works with those types? ie, are you able to log in using all of the currently supported OAuth providers on https://nova.astrometry.net/signin ?

http://stackoverflow.com/questions/20301338/django-openid-auth-typeerror-openid-yadis-manager-yadisservicemanager- object-is

XePeleato commented 8 months ago

Sadly, I couldn't test that, as I use it in a private environment with a preloaded API key.

I booted up a machine and tried to set up the OAuth providers, which was a bit cumbersome. I'll try to get that working to test it unless someone else can confirm in the meantime. Thanks!

dstndstn commented 8 months ago

Oh, right, that would be difficult to test! I can test in prod. Thanks again for the PR!

On Thu, Feb 1, 2024, 5:31 a.m. Eduardo Alonso @.***> wrote:

Sadly, I couldn't test that, as I use it in a private environment with a preloaded API key.

I booted up a machine and tried to set up the OAuth providers, which was a bit cumbersome. I'll try to get that working to test it unless someone else can confirm in the meantime. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/dstndstn/astrometry.net/pull/292#issuecomment-1921005679, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIEH7IAJZSXJLGMP6DIDXDYRNVJXAVCNFSM6AAAAABCRCO3FOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRGAYDKNRXHE . You are receiving this because you commented.Message ID: @.***>

dstndstn commented 8 months ago

I just checked and this doesn't seem to break any of the login methods! (Twitter seems to have already been broken)

dstndstn commented 8 months ago

Thank you very much!