search

dstndstn / astrometry.net

Astrometry.net -- automatic recognition of astronomical images
http://astrometry.net
Other
662 stars 186 forks source link

(CI) mirrorlist.centos.org is removed #305

Closed oldherl closed 1 week ago

oldherl commented 2 weeks ago

As CentOS7 has ended support, the domain mirrorlist.centos.org is removed and can no longer be solved. This has caused the CI for CentOS7 to be failing.

It looks like that there's a workaround of changing it to vault.centos.org . Or we should just remove the CI for CentOS7 altogether.

dstndstn commented 2 weeks ago

Thanks for investigating! Any chance you would be interested in implementing this and sending a Pull Request? :)

oldherl commented 1 week ago

Thanks for investigating! Any chance you would be interested in implementing this and sending a Pull Request? :)

But it's up to you to decide whether to continue the support for CentOS7, right?

dstndstn commented 1 week ago

I guess we can just drop it... that'll be an easy change. Is there a newer RedHat variant we should support?

oldherl commented 1 week ago

I have no idea. I am personally an Arch Linux user. I bet a better alternative would be to add ubuntu 24.04 and rocky linux 9 support.

dstndstn commented 1 week ago

It does have Ubuntu 22.04 -- https://github.com/dstndstn/astrometry.net/blob/main/.circleci/config.yml#L115

Looks like we have rocky 8.5, so adding 9 probably wouldn't be too hard -- https://github.com/dstndstn/astrometry.net/blob/main/.circleci/config.yml#L387

I have never played with Arch so have no idea, but following the formula for the closest distro would probably get you pretty far along.

But if you don't want to do this, that's fine too :)

On Wed, Sep 4, 2024 at 10:21 AM oldherl @.***> wrote:

I have no idea. I am personally an Arch Linux user. I bet a better alternative would be to add ubuntu 22.04 and rocky linux 9 support.

— Reply to this email directly, view it on GitHub https://github.com/dstndstn/astrometry.net/issues/305#issuecomment-2329205180, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIEH7NQMKRGQJN33OGAJQTZU4JPTAVCNFSM6AAAAABNFKWCWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRZGIYDKMJYGA . You are receiving this because you commented.Message ID: @.***>

oldherl commented 1 week ago

Actually I'm packaging this for Arch Linux in the [archlinuxcn] repo (https://github.com/archlinuxcn/repo/). But I don't think Arch deserves a place in the CI.

The last comment should read 24.04 and I edited it. I don't know what was the problem for it that caused the disabling though.

Sure, I can write a PR that just adds a '#' in front of the centos7 line, but that just feels a little weird for my first contribution...

dstndstn commented 1 week ago

Fair enough :)

On Wed, Sep 4, 2024 at 11:07 AM oldherl @.***> wrote:

Actually I'm packaging this for Arch Linux in the [archlinuxcn] repo ( https://github.com/archlinuxcn/repo/). But I don't think Arch deserves a place in the CI.

The last comment should read 24.04 and I edited it. I don't know what was the problem for it that caused the disabling though.

Sure, I can write a PR that just adds a '#' in front of the centos7 line, but that just feels a little weird for my first contribution...

— Reply to this email directly, view it on GitHub https://github.com/dstndstn/astrometry.net/issues/305#issuecomment-2329319438, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIEH7P6RE2EV3OO6DBSOX3ZU4O2FAVCNFSM6AAAAABNFKWCWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRZGMYTSNBTHA . You are receiving this because you commented.Message ID: @.***>

dstndstn commented 1 week ago

I just tried those changes, let's see what it does!

oldherl commented 1 week ago

Oh, please don't add centos8 as CentOS Linux 8 has reached End Of Life (EOL) on December 31st, 2021. Yeah, it's even earlier than centos7.

oldherl commented 1 week ago

https://launchpad.net/ubuntu/noble/amd64/libpython3.11-dev python 3.11 has been removed for ubuntu 24.04, please use python 3.12 instead

dstndstn commented 1 week ago

Thanks for the tips! Is there a live centos?

oldherl commented 1 week ago

They switched to "Stream", which is a rolling release style just like Arch. So I'm not sure if that is worth a CI now.

oldherl commented 1 week ago

Python 3.12 is now by default preventing the use of pip install outside a venv. I would prefer to use apt to install the python libraries apt install python3-fitsio python3-numpy.

oldherl commented 1 week ago 
depends=('bzip2' 'cairo' 'libpng' 'libjpeg-turbo' 'python-astropy' 'netpbm' 'cfitsio' 'gsl' 'swig')
makedepends=('python-setuptools')

This is the dependency list I use on Arch. Maybe you could find the equivalents on Ubuntu. Good luck :)

dstndstn commented 1 week ago

Looks like it's working, shall we close this ticket?

oldherl commented 1 week ago

Fixed in bf2826d