search

dstndstn / astrometry.net

Astrometry.net -- automatic recognition of astronomical images
http://astrometry.net
Other
683 stars 189 forks source link

Conflicting files installation with cfitsio #310

Closed mattiaverga closed 1 month ago

mattiaverga commented 1 month ago

Some files installed by astrometry (fitscopy, fitsverify, imcopy) are conflicting with files provided by cfitsio system's package. Would it be possible to avoid bundling them and properly link to cfitsio provided headers? Or, at least, rename them so to discriminate from cfitsio provided ones?

dstndstn commented 1 month ago

For the longest time, the cfitsio package did not install those binaries. Does it do that now?

mattiaverga commented 1 month ago

It seems so. I'm packaging astrometry in Fedora Linux and I got a report from the other maintainer of the cfitsio package about those conflicting files. From what I see, they're now manually excluding installing some files to avoid conflicts:

make DESTDIR=%{buildroot} install
#
rm %{buildroot}/%{_bindir}/cookbook
rm %{buildroot}/%{_bindir}/fitsverify
rm %{buildroot}/%{_bindir}/fitscopy
rm %{buildroot}/%{_bindir}/imcopy
rm %{buildroot}/%{_bindir}/smem
rm %{buildroot}/%{_bindir}/speed

The plan is to move those programs under a cfitsio-utils subpackage to provide them by "official" upstream. I could just remove the astrometry generated files in the astrometry RPM, if this is something you prefer to not "fix" upstream.

dstndstn commented 1 month ago

Thanks for your answer. It looks like Ubuntu now also packages those as libcfitsio-bin. So I would be fine only installing those with a special make command (make install-cfitsio or something like that).

dstndstn commented 1 month ago

(We do already use the cfitsio header and library; it's just that cfitsio used to not install those very useful "example" programs.)