msvc: capstone: Move to using upstream instead of vcpkg

weltling commented 1 year ago

Moving to the usage of the upstream sources removes layers of complexity present in VCPKG and allows for more flexibility with regard to the dependency handling. Things done:

Switch to building capstone based from an upstream tag
Explicitly remove any unused arch support in the build
Use static lib to simplify on-prem usage
Cache the capstone artifacts in the pipeline
Automatically reset cache based on the values in Makefile and VC++ toolset version

The current capstone version is still kept 5.0-rc2. While evaluating a possible downgrade to 4.0.2 as used by the Linux CI, some test regressions are observed on the x64 side. If needed, those might be spent a closer look, otherwise keeping the version seems ok.

dstogov commented 1 year ago

Great! The build is green again. Thank you very much.

It may make sense to separate everything capstone related into a separate Makefile. (e.g. win32/third-party/capstone/Makefile) and call nested make.

weltling commented 1 year ago

Thanks for the quick check. Indeed, with the nested makefile, it'll make it cleaner. I'll plan to evaluate further on that.

Thanks

dstogov commented 1 year ago

It looks like something is broken again See https://github.com/dstogov/ir/actions/runs/5270236470/jobs/9529458175

weltling commented 1 year ago

Huh, weird it is. I'll plan to do another pass on that. At the first glance, VC++ toolset version has changed in the failing run.

Thanks

dstogov / ir

msvc: capstone: Move to using upstream instead of vcpkg #43