search

dstorey / stale

Web docs and other resources become stale over time. Help report and fix outdated content.
50 stars 2 forks source link

game-shim doesn’t include ms prefixes #50

Open dstorey opened 10 years ago

dstorey commented 10 years ago

URL: https://github.com/toji/game-shim/blob/master/game-shim.js#L106

Some issues and potential future issues:

Contact: @toji (author)

toji commented 10 years ago

This library is in pretty sorry shape anyway, as I haven't updated it for a while. I don't know how much effort I want to put into it going forward either, since many of these APIs are fully cross-platform now (requestAnimationFrame should "just work" everywhere now, Gamepad is unprefixed in FF and Chrome, etc.)

I'll still take a look though. Shouldn't be a ton of effort to do those updates. On Mon, Apr 21, 2014 at 12:00 AM, David Storey notifications@github.com wrote:

URL: https://github.com/toji/game-shim/blob/master/game-shim.js#L106

Some issues and potential future issues:

  • Fullscreen API checks for unprefixed fullscreen API. If not supported it checks for moz and webkit prefixes. IE11+ supports the fullscreen API with ms prefixes (and modern lowercase "s" syntax), which won't be picked up.
  • The Pointer Lockhttps://github.com/toji/game-shim/blob/master/game-shim.js#L203code potentially has the same issue, but MS hasn’t announced support http://status.modern.ie/pointerlockmouselock yet or if they’ll use a prefix or not.
  • The Gamepad APIhttps://github.com/toji/game-shim/blob/master/game-shim.js#L306code also potentially has the same issue. IE have announced support http://status.modern.ie/gamepadapi but it is not clear if a prefix will be used. If so, this will need to be updated too. I’ve asked for clarification about the current situation with the PM in question.

Contact: @toji https://github.com/toji (author)

— Reply to this email directly or view it on GitHubhttps://github.com/dstorey/stale/issues/50 .

dstorey commented 10 years ago

@toji does Chrome implement GamePad like Firefox now in its unprefixed form? Do you know from which version? I’ve not seen any article yet mention unprefixed in Chrome. Will have to add that to my update notes for the other articles in this repo.

toji commented 10 years ago

I added an unprefixed implementation that matches the latest spec (mostly compatible w/ FF) in Chrome 35. (I think. Hard to keep track of versions) it should be available in Chrome Beta and up. On Mon, Apr 21, 2014 at 10:18 AM, David Storey notifications@github.com wrote:

@toji https://github.com/toji does Chrome implement GamePad like Firefox now in its unprefixed form? Do you know from which version? I’ve not seen any article yet mention unprefixed in Chrome. Will have to add that to my update notes for the other articles in this repo.

— Reply to this email directly or view it on GitHubhttps://github.com/dstorey/stale/issues/50#issuecomment-40948351 .